Skip to content

Commit

Permalink
Disable uwsgi, pyaudio, jack-client stubtest on macOS (python#11821)
Browse files Browse the repository at this point in the history
  • Loading branch information
hauntsaninja authored Apr 24, 2024
1 parent 7ed91bc commit 29db988
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 13 deletions.
4 changes: 2 additions & 2 deletions stubs/JACK-Client/METADATA.toml
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ requires = ["numpy>=1.20", "types-cffi"]

[tool.stubtest]
# darwin and win32 are equivalent
platforms = ["darwin", "linux"]
platforms = ["linux"]
apt_dependencies = ["libjack-dev"]
brew_dependencies = ["jack"]
# brew_dependencies = ["jack"]
# No need to install on the CI. Leaving here as information for Windows contributors.
# choco_dependencies = ["jack"]
4 changes: 2 additions & 2 deletions stubs/pyaudio/METADATA.toml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@ version = "0.2.*"

[tool.stubtest]
# linux and win32 are equivalent
platforms = ["darwin", "linux"]
platforms = ["linux"]
apt_dependencies = ["portaudio19-dev"]
brew_dependencies = ["portaudio"]
# brew_dependencies = ["portaudio"]
5 changes: 1 addition & 4 deletions stubs/uWSGI/METADATA.toml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,4 @@ extra_description = """\
"""

[tool.stubtest]
# Run stubtest on MacOS as well, to check that the
# uWSGI-specific parts of stubtest_third_party.py
# also work there
platforms = ["linux", "darwin"]
platforms = ["linux"]
8 changes: 4 additions & 4 deletions tests/parse_metadata.py
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ class StubtestSettings:
Don't construct instances directly; use the `read_stubtest_settings` function.
"""

skipped: bool
skip: bool
apt_dependencies: list[str]
brew_dependencies: list[str]
choco_dependencies: list[str]
Expand All @@ -79,7 +79,7 @@ def read_stubtest_settings(distribution: str) -> StubtestSettings:
with Path("stubs", distribution, "METADATA.toml").open("rb") as f:
data: dict[str, object] = tomli.load(f).get("tool", {}).get("stubtest", {})

skipped: object = data.get("skip", False)
skip: object = data.get("skip", False)
apt_dependencies: object = data.get("apt_dependencies", [])
brew_dependencies: object = data.get("brew_dependencies", [])
choco_dependencies: object = data.get("choco_dependencies", [])
Expand All @@ -88,7 +88,7 @@ def read_stubtest_settings(distribution: str) -> StubtestSettings:
specified_platforms: object = data.get("platforms", ["linux"])
stubtest_requirements: object = data.get("stubtest_requirements", [])

assert type(skipped) is bool
assert type(skip) is bool
assert type(ignore_missing_stub) is bool

# It doesn't work for type-narrowing if we use a for loop here...
Expand All @@ -110,7 +110,7 @@ def read_stubtest_settings(distribution: str) -> StubtestSettings:
)

return StubtestSettings(
skipped=skipped,
skip=skip,
apt_dependencies=apt_dependencies,
brew_dependencies=brew_dependencies,
choco_dependencies=choco_dependencies,
Expand Down
2 changes: 1 addition & 1 deletion tests/stubtest_third_party.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ def run_stubtest(
print(f"{dist_name}... ", end="", flush=True)

stubtest_settings = metadata.stubtest_settings
if stubtest_settings.skipped:
if stubtest_settings.skip:
print(colored("skipping", "yellow"))
return True

Expand Down

0 comments on commit 29db988

Please sign in to comment.