Skip to content

Commit

Permalink
openpyxl: CellRange: title should not be required (python#10688)
Browse files Browse the repository at this point in the history
  • Loading branch information
oefe authored Sep 10, 2023
1 parent 703ed36 commit 011b5b9
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions stubs/openpyxl/openpyxl/worksheet/cell_range.pyi
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,7 @@ class CellRange(Serialisable):
min_row: MinMax[int, Literal[False]]
max_col: MinMax[int, Literal[False]]
max_row: MinMax[int, Literal[False]]
# Could be None if the caller forgot to set title and range_string doesn't contain "!"
# but that's not intended and will lead to errors (ie: can't be None in __str__)
title: str
title: str | None

@overload
def __init__(
Expand All @@ -35,7 +33,7 @@ class CellRange(Serialisable):
min_row: _ConvertibleToInt,
max_col: _ConvertibleToInt,
max_row: _ConvertibleToInt,
title: str,
title: str | None = None,
) -> None: ...
@property
def bounds(self): ...
Expand Down

0 comments on commit 011b5b9

Please sign in to comment.