Skip to content

Commit

Permalink
kvcoord: raise ambiguous errors on batches with commit
Browse files Browse the repository at this point in the history
WIP: This intends to raise an error on a KV batch that has an ambiguous
error on one of its writes, and also has an `EndTxn` request in the
batch.

Part of: cockroachdb#103817

Release note (bug fix): TBD
  • Loading branch information
AlexTalks committed Jul 14, 2023
1 parent a6dbdee commit 70047cf
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pkg/kv/kvclient/kvcoord/dist_sender.go
Original file line number Diff line number Diff line change
Expand Up @@ -2340,7 +2340,7 @@ func (ds *DistSender) sendToReplicas(
// evaluating twice, overwriting another unrelated write that fell
// in-between.
//
if withCommit && !grpcutil.RequestDidNotStart(err) {
if withCommit {
ambiguousError = err
}
log.VErrEventf(ctx, 2, "RPC error: %s", err)
Expand Down

0 comments on commit 70047cf

Please sign in to comment.