[Bug]: spawn biome json files are broken if using with biome mods.

[greanthai420]

What happened?

With mod Terralith.
Tested with "Generate Dragon Roost Chance" = 1 and with fire_dragon_biomes.json

Config examples that spawns:

{
  "biomes": [
    [      
      {
        "type": "BIOME_TAG",
        "negate": false,
        "value": "forge:is_hot/overworld"
      }
    ]
  ]
}

{
  "biomes": [
    [      
      {
        "type": "BIOME_TAG",
        "negate": false,
        "value": "forge:is_cold/overworld"
      }
    ]
  ]
}

Config examples that don't seem to spawn at all:
BIOME_TAG forge:is_desert
BIOME_TAG forge:is_plains

Seems that all tags that doesn't have /overworld at the end doesn't work.
If using without Terralith BIOME_TAG forge:is_desert works as intended.

Minecraft Version

1.20.1

Ice and Fire version

alpha 7

Citadel version

2.4.9

Relevant log output

no logs lol

Other Information

• I am using other mods besides Ice and Fire
• I have attached a log file from the session that I have experienced this issue

[SiverDX]

checked myself, the tags work fine
there is no real logic against one or the other, if the tag exists in the minecraft registry it will be properly handled (which it does)
The first tag you mention simply has more biomes added to it, incl. some caves -> https://github.com/Stardust-Labs-MC/Terralith/blob/1.20/data/forge/tags/worldgen/biome/is_hot/overworld.json

---

i did notice that terraliths deep caves cause problems with certain features

Checking [iceandfire:fire_dragon_roost] against [terralith:cave/deep_caves]
Checking [iceandfire:myrmex_hive_desert] against [terralith:cave/deep_caves]
Checking [iceandfire:spawn_death_worm] against [terralith:cave/deep_caves]
Checking [iceandfire:spawn_dragon_skeleton_fire] against [terralith:cave/deep_caves]
Checking [iceandfire:lightning_dragon_roost] against [terralith:cave/deep_caves]
Checking [iceandfire:spawn_dragon_skeleton_lightning] against [terralith:cave/deep_caves]
Checking [iceandfire:fire_dragon_cave] against [terralith:cave/deep_caves]
Checking [iceandfire:lightning_dragon_cave] against [terralith:cave/deep_caves]

normally this would look like this

Checking [iceandfire:fire_dragon_roost] against [minecraft:plains]
Checking [iceandfire:myrmex_hive_desert] against [minecraft:plains]
Checking [iceandfire:spawn_death_worm] against [minecraft:plains]
Checking [iceandfire:spawn_dragon_skeleton_fire] against [minecraft:plains]
Checking [iceandfire:spawn_wandering_cyclops] against [minecraft:plains]
Checking [iceandfire:fire_dragon_cave] against [minecraft:plains]

[greanthai420]

Thanks for the reply.
Here's how to reproduce.
/locate biome #forge:is_hot/overworld then tp, will see roosts everywhere.

but if I use
/locate biome #forge:is_desert then tp, no roosts anywhere. Also tried going into every is_desert biomes and roosts are nowhere to be found.

[SiverDX]

is_desert probably would probably work if you add the terralith cave biomes to it
not that there is any reason to do so

[greanthai420]

Adding terralith:cave/deep_caves into is_desert then using forge:is_desert as spawn seems to make the roosts spawn in every biomes.
Maybe problems with how terralith assigns the tags?

[SiverDX]

the problem is terralith worldgen and how biomes get recognized when its present
with terralith you have a cave and surface biome and the default biome filter seems to pass the lowest y point

might need to make a custom one to check surface biome with a fitting world height

[greanthai420]

Sorry if I sound stupid, but in that case shouldn't this work? Assuming that the roosts are spawning underground making on-ground roosts not spawning? (deep_caves is in is_underground)

{
  "biomes": [
    [      
      {
        "type": "BIOME_TAG",
        "negate": false,
        "value": "forge:is_desert"
      },
	  {
        "type": "BIOME_TAG",
        "negate": true,
        "value": "forge:is_underground"
      }
    ]
  ]
}

[SiverDX]

thing is some of these caves are generic, like deep_cave
they don't belong to a specific biome or type of biome

[TheBv]

I will plan on rewriting how caves will be generated in future releases so they look at the overworld biome to decide where to generate to circumvent this issue.

[SiverDX]

already did that here https://github.com/SiverDX/Ice_and_Fire/blob/1.19.2/src/main/java/com/github/alexthe666/iceandfire/world/CustomBiomeFilter.java