fix error message for is.number assertion (closes DevExpress#2470)

AlexKamaev · Jun 22, 2018 · 826cbf7 · 826cbf7
1 parent be2206f
commit 826cbf7
Show file tree

Hide file tree

Showing 3 changed files with 37 additions and 2 deletions.
diff --git a/src/errors/runtime/type-assertions.js b/src/errors/runtime/type-assertions.js
@@ -15,8 +15,9 @@ function isNonNegativeValue (value) {
 
 export var is = {
     number: {
-        name:      'number',
-        predicate: isFiniteNumber
+        name:              'number',
+        predicate:         isFiniteNumber,
+        getActualValueMsg: (value, type) => type === 'number' ? value : type
     },
 
     nonNegativeNumber: {

diff --git a/test/server/api-test.js b/test/server/api-test.js
@@ -565,6 +565,32 @@ describe('API', function () {
                 });
         });
 
+        it('Should raise `it was NaN` error if Selector.nth() `index` argument is NaN', function () {
+            var testfile = resolve('test/server/data/test-suites/selector-nth-arg-is-nan-value/testfile.js');
+
+            return compile(testfile)
+                .then(function () {
+                    throw new Error('Promise rejection expected');
+                })
+                .catch(function (err) {
+                    assertAPIError(err, {
+                        stackTop: testfile,
+
+                        message: 'Cannot prepare tests due to an error.\n\n' +
+                                 '"index" argument is expected to be a number, but it was NaN.',
+
+                        callsite: "   1 |import { Selector } from 'testcafe';\n" +
+                                  '   2 |\n' +
+                                  '   3 |fixture `Test`;\n' +
+                                  '   4 |\n' +
+                                  ' > 5 |Selector(() => {}).nth(NaN);\n' +
+                                  '   6 |\n' +
+                                  "   7 |test('yo', () => {\n" +
+                                  '   8 |});'
+                    });
+                });
+        });
+
         it('Should raise an error if Selector.nth() `index` argument is not a number', function () {
             var testfile = resolve('test/server/data/test-suites/selector-nth-arg-is-a-number-value/testfile.js');
 

diff --git a/test/server/data/test-suites/selector-nth-arg-is-nan-value/testfile.js b/test/server/data/test-suites/selector-nth-arg-is-nan-value/testfile.js
@@ -0,0 +1,8 @@
+import { Selector } from 'testcafe';
+
+fixture `Test`;
+
+Selector(() => {}).nth(NaN);
+
+test('yo', () => {
+});