Added tests to detect pooled buffer leaks (Azure#10)

* reorganized folders * Added buffer management tests
AlexGhiondea · Nov 30, 2018 · d58a31c · d58a31c
1 parent e45dfbd
commit d58a31c
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 5 deletions.
diff --git a/Azure.Configuration.Test/ConfigurationTests.cs b/Azure.Configuration.Test/ConfigurationTests.cs
@@ -8,6 +8,7 @@
 using System.Threading;
 using System.Threading.Tasks;
 using Azure.Configuration.Test;
+using Azure.Core.Testing;
 
 namespace Azure.Configuration.Tests
 {
@@ -29,20 +30,25 @@ public async Task SetKeyValue()
             string connectionString = "Endpoint=https://contoso.azconfig.io;Id=b1d9b31;Secret=aabbccdd";
             ConfigurationService.ParseConnectionString(connectionString, out var uri, out var credential, out var secret);
 
+            var service = new ConfigurationService(uri, credential, secret);
+
             var transport = new SetKeyValueMockTransport();
             transport.KeyValue = s_testKey;
             transport.Responses.Add(HttpStatusCode.NotFound);
             transport.Responses.Add(HttpStatusCode.OK);
-
-            var service = new ConfigurationService(uri, credential, secret);
             service.Pipeline.Transport = transport;
+            var pool = new TestPool<byte>();
+            service.Pipeline.Pool = pool;
 
             Response<KeyValue> added = await service.SetKeyValueAsync(s_testKey, CancellationToken.None);
 
             Assert.AreEqual(s_testKey.Key, added.Result.Key);
             Assert.AreEqual(s_testKey.Label, added.Result.Label);
             Assert.AreEqual(s_testKey.ContentType, added.Result.ContentType);
             Assert.AreEqual(s_testKey.Locked, added.Result.Locked);
+
+            added.Dispose();
+            Assert.AreEqual(0, pool.CurrentlyRented);
         }
 
         [Test]
@@ -51,13 +57,15 @@ public async Task GetKeyValue()
             string connectionString = "Endpoint=https://contoso.azconfig.io;Id=b1d9b31;Secret=aabbccdd";
             ConfigurationService.ParseConnectionString(connectionString, out var uri, out var credential, out var secret);
 
+            var service = new ConfigurationService(uri, credential, secret);
+
             var transport = new GetKeyValueMockTransport();
             transport.KeyValue = s_testKey;
             transport.Responses.Add(HttpStatusCode.NotFound);
             transport.Responses.Add(HttpStatusCode.OK);
-
-            var service = new ConfigurationService(uri, credential, secret);
             service.Pipeline.Transport = transport;
+            var pool = new TestPool<byte>();
+            service.Pipeline.Pool = pool;
 
             Response<KeyValue> added = await service.GetKeyValueAsync("test", default, CancellationToken.None);
 

diff --git a/Azure.Configuration/ConfigurationService.cs b/Azure.Configuration/ConfigurationService.cs
@@ -86,7 +86,7 @@ public async Task<Response<KeyValue>> SetKeyValueAsync(KeyValue setting, Cancell
             }
         }
 
-        public async Task<Response<KeyValue>> GetKeyValueAsync(string key, GetKeyValueOptions options, CancellationToken cancellation)
+         public async Task<Response<KeyValue>> GetKeyValueAsync(string key, GetKeyValueOptions options, CancellationToken cancellation)
         {
             if (string.IsNullOrEmpty(key)) {
                 throw new ArgumentNullException(nameof(key));