Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump major version to 5.0.0 #928

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Bump major version to 5.0.0 #928

merged 1 commit into from
Jun 25, 2024

Conversation

MerlinKallenbornAA
Copy link
Collaborator

@MerlinKallenbornAA MerlinKallenbornAA commented Jun 25, 2024 •
edited
Loading

Description

Bump major version to v5.0.0 for release

Before Merging

  • Review the code changes
    • Unused print / comments / TODOs
    • Missing docstrings for functions that should have them
    • Consistent variable names
    • ...
  • Update changelog.md if necessary
  • [] Commit messages should contain a semantic label and the ticket number
    • Consider squashing if this is not the case

@MerlinKallenbornAA MerlinKallenbornAA marked this pull request as ready for review June 25, 2024 09:57
maxhammeralephalpha
maxhammeralephalpha approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@maxhammeralephalpha maxhammeralephalpha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MerlinKallenbornAA MerlinKallenbornAA merged commit 2ad73f4 into main Jun 25, 2024
4 checks passed
@MerlinKallenbornAA MerlinKallenbornAA deleted the release-v500 branch June 25, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxhammeralephalpha maxhammeralephalpha maxhammeralephalpha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MerlinKallenbornAA @maxhammeralephalpha