Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Phs 520 resume after failed #918

Merged
merged 11 commits into from
Jun 19, 2024
Merged

Phs 520 resume after failed #918

merged 11 commits into from
Jun 19, 2024

Conversation

SebastianNiehusAA
Copy link
Contributor

@SebastianNiehusAA SebastianNiehusAA commented Jun 19, 2024 •
edited
Loading

Description

No description.

Before Merging

  • Review the code changes
    • Unused print / comments / TODOs
    • Missing docstrings for functions that should have them
    • Consistent variable names
    • ...
  • Update changelog.md if necessary
  • Commit messages should contain a semantic label and the ticket number
    • Consider squashing if this is not the case

FelixFehse and others added 11 commits June 18, 2024 13:55
@FelixFehse
WIP feat: resume runs after failed PHS-520
3c6ae05
@SebastianNiehusAA @FelixFehse
feat: Add examples_to_skip parameter to `DatasetRepository.examples…
550ec38 
…` interface and derive methods

TASK:PHS-520
@FelixFehse
WIP: implement temporary file logging PHS-520
c70dcbd
@SebastianNiehusAA @FelixFehse
feat: Refine test for run tracking
47eece8 
Task: PHS-520
@SebastianNiehusAA @FelixFehse
feat: Refactor file format for tmp run file into json
9b4b613 
Task: PHS-520
@SebastianNiehusAA @FelixFehse
feat: Create class RecoveryData
cbbd485 
Task: PHS-520
@FelixFehse
feat: runner can resume failed examples
077c053
@FelixFehse
fix: all tests passing
673a895
@SebastianNiehusAA
feat: Change behavior of example_outputs on nonexistent run_id.
8d37830 
Task: PHS-520
@SebastianNiehusAA
feat: Enable resuming of InMemoryRunRepository based Runners
d5f9ce0 
 * Unify behavior of example_output and example_outputs
 * Refactor tests

Task: PHS-520
@SebastianNiehusAA
feat: Update CHANGELOG.md
a83f9a9 
Task: PHS-520
@SebastianNiehusAA SebastianNiehusAA merged commit 1237e88 into main Jun 19, 2024
4 checks passed
@SebastianNiehusAA SebastianNiehusAA deleted the PHS-520-resume-after-failed branch June 19, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SebastianNiehusAA @FelixFehse