Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/argilla text question #905

Merged
merged 8 commits into from
Jun 12, 2024
Merged

Conversation

steiner-julian
Copy link
Contributor

Description

No description.

Before Merging

  • [ x ] Review the code changes
    • Unused print / comments / TODOs
    • Missing docstrings for functions that should have them
    • Consistent variable names
    • ...
  • [ x ] Update changelog.md if necessary
  • [ x ] Commit messages should contain a semantic label and the ticket number
    • Consider squashing if this is not the case

@SebastianNiehusAA SebastianNiehusAA self-requested a review June 11, 2024 12:46
@SebastianNiehusAA
Copy link
Contributor

Thank you for the PR!
I fixed some of the linter errors, but there are still 9 issues left.
Could you please check out the changes and run ./scripts/lint.sh from the project root folder?
This should give a the list of the following errors:

.../argilla_client.py:70: error: Dict entry 1 has incompatible type "str": "list[dict[str, int]]"; expected "str": "str"  [dict-item]
.../argilla_client.py:86: error: Dict entry 1 has incompatible type "str": "bool"; expected "str": "str"  [dict-item]
.../argilla_client.py:281: error: No overload variant of "__getitem__" of "Sequence" matches argument type "str"  [call-overload]
.../argilla_client.py:281: note: Possible overload variants:
.../argilla_client.py:281: note:     def __getitem__(self, int, /) -> Any
.../argilla_client.py:281: note:     def __getitem__(self, slice, /) -> Sequence[Any]
.../argilla_client.py:303: error: "Question" has no attribute "settings"  [attr-defined]
.../argilla_client.py:338: error: Name "dataset_id" already defined on line 326  [no-redef]
.../argilla_client.py:357: error: "Question" has no attribute "settings"  [attr-defined]
.../argilla_evaluator.py:258: error: Unexpected keyword argument "options" for "Question"  [call-arg]
.../test_argilla_evaluator.py:113: error: Unexpected keyword argument "options" for "Question"  [call-arg]
.../test_argilla_evaluator.py:255: error: Unexpected keyword argument "options" for "Question"  [call-arg]

@SebastianNiehusAA SebastianNiehusAA force-pushed the feature/argilla-text-question branch from a44370c to 9da785f Compare June 12, 2024 09:35
@SebastianNiehusAA SebastianNiehusAA merged commit 97b1497 into main Jun 12, 2024
4 checks passed
@SebastianNiehusAA SebastianNiehusAA deleted the feature/argilla-text-question branch June 12, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants