Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: expand chunk index error for large texts #901

Merged
merged 3 commits into from
Jun 11, 2024
Merged

fix: expand chunk index error for large texts #901

merged 3 commits into from
Jun 11, 2024

Conversation

NiklasKoehneckeAA
Copy link
Contributor

@NiklasKoehneckeAA NiklasKoehneckeAA commented Jun 10, 2024 •
edited
Loading

Description

Fixes an issue where indices were not properly passed when sub-chunking a text that started in the middle of a different text

Before Merging

  • Review the code changes
    • Unused print / comments / TODOs
    • Missing docstrings for functions that should have them
    • Consistent variable names
    • ...
  • Update changelog.md if necessary
  • Commit messages should contain a semantic label and the ticket number
    • Consider squashing if this is not the case

@NiklasKoehneckeAA NiklasKoehneckeAA merged commit 19f5ad0 into main Jun 11, 2024
4 checks passed
@NiklasKoehneckeAA NiklasKoehneckeAA deleted the fix-expand-chunk branch June 11, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MerlinKallenbornAA MerlinKallenbornAA MerlinKallenbornAA approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NiklasKoehneckeAA @MerlinKallenbornAA