Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Replace langdetect with lingua #897

Merged
merged 3 commits into from
Jun 7, 2024
Merged

feat: Replace langdetect with lingua #897

merged 3 commits into from
Jun 7, 2024

Conversation

MerlinKallenbornAA
Copy link
Collaborator

@MerlinKallenbornAA MerlinKallenbornAA commented Jun 7, 2024 •
edited
Loading

TASK: IL-416

Description

No description.

Before Merging

  • Review the code changes
    • Unused print / comments / TODOs
    • Missing docstrings for functions that should have them
    • Consistent variable names
    • ...
  • Update changelog.md if necessary
  • Commit messages should contain a semantic label and the ticket number
    • Consider squashing if this is not the case

@MerlinKallenbornAA MerlinKallenbornAA force-pushed the IL-416-lingua-eval branch 2 times, most recently from 67375cd to 80233ad Compare June 7, 2024 13:29
@MerlinKallenbornAA MerlinKallenbornAA merged commit accd7bb into main Jun 7, 2024
4 checks passed
@MerlinKallenbornAA MerlinKallenbornAA deleted the IL-416-lingua-eval branch June 7, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MerlinKallenbornAA