Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Throw a warning instead of an error incase a non recommended mod… #892

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Fix: Throw a warning instead of an error incase a non recommended mod… #892

merged 1 commit into from
Jun 6, 2024

Conversation

FlorianSchepersAA
Copy link
Contributor

@FlorianSchepersAA FlorianSchepersAA commented Jun 4, 2024 •
edited
Loading

…el is selected for a ControlMode.

Task: IL-546

Description

No description.

Before Merging

  • Review the code changes
    • Unused print / comments / TODOs
    • Missing docstrings for functions that should have them
    • Consistent variable names
    • ...
  • Update changelog.md if necessary
  • Commit messages should contain a semantic label and the ticket number
    • Consider squashing if this is not the case

@FlorianSchepersAA FlorianSchepersAA force-pushed the IL-546-model-support branch 5 times, most recently from 3196a47 to 08d86a9 Compare June 6, 2024 12:57
@FlorianSchepersAA FlorianSchepersAA force-pushed the IL-546-model-support branch 2 times, most recently from 96e58c2 to 8aeb711 Compare June 6, 2024 14:04
@FlorianSchepersAA
fix: Throw a warning instead of an error incase a non recommended mod…
422b0bc 
…el is selected for a ControlMode.

Task: IL-546
@FlorianSchepersAA FlorianSchepersAA merged commit fcd9908 into main Jun 6, 2024
4 checks passed
@FlorianSchepersAA FlorianSchepersAA deleted the IL-546-model-support branch June 6, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NiklasKoehneckeAA NiklasKoehneckeAA NiklasKoehneckeAA left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FlorianSchepersAA @NiklasKoehneckeAA