Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: aggregation of aggregation #885

Merged
merged 4 commits into from
May 31, 2024
Merged

feat: aggregation of aggregation #885

merged 4 commits into from
May 31, 2024

Conversation

NiklasKoehneckeAA
Copy link
Contributor

@NiklasKoehneckeAA NiklasKoehneckeAA commented May 31, 2024 •
edited by SebastianNiehusAA
Loading

Description

No description.

Before Merging

  • Review the code changes
    • Unused print / comments / TODOs
    • Missing docstrings for functions that should have them
    • Consistent variable names
    • ...
  • Update changelog.md if necessary
  • Commit messages should contain a semantic label and the ticket number
    • Consider squashing if this is not the case

@SebastianNiehusAA SebastianNiehusAA force-pushed the IL-419-aggregation-of-aggregation branch from 4d364dd to ebe7387 Compare May 31, 2024 14:51
@SebastianNiehusAA SebastianNiehusAA merged commit 31df7b3 into main May 31, 2024
4 checks passed
@SebastianNiehusAA SebastianNiehusAA deleted the IL-419-aggregation-of-aggregation branch May 31, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NiklasKoehneckeAA @SebastianNiehusAA