Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: naming in argilla evaluator #879

Merged

Conversation

NiklasKoehneckeAA
Copy link
Contributor

@NiklasKoehneckeAA NiklasKoehneckeAA commented May 29, 2024

TASK: IL-541

Description

No description.

Before Merging

  • Review the code changes
    • Unused print / comments / TODOs
    • Missing docstrings for functions that should have them
    • Consistent variable names
    • ...
  • Update changelog.md if necessary
  • Commit messages should contain a semantic label and the ticket number
    • Consider squashing if this is not the case

refactor: Move fixture for DefaultArgillaClient to evluation/conftest.py

TASK: IL-541
@NiklasKoehneckeAA NiklasKoehneckeAA changed the title WIP: feat: Add test for submit two different datasets WIP: fix: naming in argilla evaluator May 29, 2024
@NiklasKoehneckeAA NiklasKoehneckeAA changed the title WIP: fix: naming in argilla evaluator fix: naming in argilla evaluator May 29, 2024
 * Fixed outdated run parameters in Concepts.md
TASK: IL-541
@SebastianNiehusAA SebastianNiehusAA merged commit 88e5def into main May 30, 2024
1 of 4 checks passed
@SebastianNiehusAA SebastianNiehusAA deleted the IL-541-fix-bug-in-argilla-evaluator-submit-method branch May 30, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants