Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add function to upload to trace viewer to Tracer. #870

Merged
merged 6 commits into from
Jun 4, 2024

Conversation

FlorianSchepersAA
Copy link
Contributor

@FlorianSchepersAA FlorianSchepersAA commented May 27, 2024

TASK: IL-496

Description

  • feat: FileTracer can convert files to new format
  • All Tracers have a submit_to_trace_viewer() method.

Before Merging

  • Review the code changes
    • Unused print / comments / TODOs
    • Missing docstrings for functions that should have them
    • Consistent variable names
    • ...
  • Update changelog.md if necessary
  • Commit messages should contain a semantic label and the ticket number
    • Consider squashing if this is not the case

@FlorianSchepersAA FlorianSchepersAA force-pushed the IL-496-upload-to-trace-viewer branch from 2763a58 to a04cfcc Compare May 27, 2024 15:48
@NiklasKoehneckeAA NiklasKoehneckeAA force-pushed the IL-496-upload-to-trace-viewer branch 2 times, most recently from baa4f26 to 8931289 Compare May 30, 2024 09:35
@FlorianSchepersAA FlorianSchepersAA force-pushed the IL-496-upload-to-trace-viewer branch 3 times, most recently from 4e73b1f to b105eab Compare June 3, 2024 08:46
@FelixFehse FelixFehse force-pushed the IL-496-upload-to-trace-viewer branch 3 times, most recently from 285445b to 13906dd Compare June 3, 2024 09:53
@SebastianNiehusAA SebastianNiehusAA force-pushed the IL-496-upload-to-trace-viewer branch 3 times, most recently from a224e3b to f3974d1 Compare June 4, 2024 12:19
@SebastianNiehusAA SebastianNiehusAA force-pushed the IL-496-upload-to-trace-viewer branch from f3974d1 to 3cd8587 Compare June 4, 2024 12:26
@SebastianNiehusAA SebastianNiehusAA merged commit 725c713 into main Jun 4, 2024
4 checks passed
@SebastianNiehusAA SebastianNiehusAA deleted the IL-496-upload-to-trace-viewer branch June 4, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants