Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme to close PR 818 #866

Merged
merged 1 commit into from
May 23, 2024
Merged

Conversation

SebastianNiehusAA
Copy link
Contributor

Description

Changes in this PR are mainly contributions by joshuakraftaa.
The original PR however has been inactive for some weeks and it has become easier to copy the changes manually.
This will close PR #818

Before Merging

  • Review the code changes
    • Unused print / comments / TODOs
    • Missing docstrings for functions that should have them
    • Consistent variable names
    • ...
  • Update changelog.md if necessary
  • Commit messages should contain a semantic label and the ticket number
    • Consider squashing if this is not the case

@SebastianNiehusAA SebastianNiehusAA force-pushed the update-readme-to-close-pr-818 branch 2 times, most recently from 4bd7975 to 7a08ba7 Compare May 23, 2024 13:28
@SebastianNiehusAA SebastianNiehusAA mentioned this pull request May 23, 2024
3 tasks
…raftaa

 * Moved endpoint configuration down to the tutorials
 * Simplified the description of poetry installation
 * Minor fixes
@SebastianNiehusAA SebastianNiehusAA force-pushed the update-readme-to-close-pr-818 branch from b4a115f to b9f4978 Compare May 23, 2024 13:44
@SebastianNiehusAA SebastianNiehusAA merged commit e7aae23 into main May 23, 2024
4 checks passed
@SebastianNiehusAA SebastianNiehusAA deleted the update-readme-to-close-pr-818 branch May 23, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant