Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated Document Index Notebook to use MultipleChunkRetrieverQa instead of RetrieverBasedQa #835

Merged
merged 2 commits into from
May 15, 2024
Merged

Updated Document Index Notebook to use MultipleChunkRetrieverQa instead of RetrieverBasedQa #835

merged 2 commits into from
May 15, 2024

Conversation

HelmholtzW
Copy link
Contributor

Description

Updated Document Index Notebook to use MultipleChunkRetrieverQa instead of RetrieverBasedQa as it's deprecated.

Before Merging

  • Review the code changes
    • Unused print / comments / TODOs
    • Missing docstrings for functions that should have them
    • Consistent variable names
    • ...
  • Update changelog.md if necessary
  • Commit messages should contain a semantic label and the ticket number
    • Consider squashing if this is not the case

@SebastianNiehusAA SebastianNiehusAA self-requested a review May 15, 2024 06:56
@SebastianNiehusAA SebastianNiehusAA self-assigned this May 15, 2024
@SebastianNiehusAA
Copy link
Contributor

Looks good. Thank you for the MR

@SebastianNiehusAA SebastianNiehusAA merged commit 0d25e19 into Aleph-Alpha:main May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SebastianNiehusAA SebastianNiehusAA SebastianNiehusAA approved these changes

Assignees

@SebastianNiehusAA SebastianNiehusAA

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HelmholtzW @SebastianNiehusAA