Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(doc): Fix docs for docker service #728

Merged
merged 1 commit into from
Apr 11, 2024
Merged

(doc): Fix docs for docker service #728

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/examples/issue_classification_user_journey.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -747,11 +747,11 @@
"TODO: Describe how to set environment variables \n",
"\n",
"### FastAPI service\n",
"TODO: Describe FastAPI setup for `ClassificationService.py` \n",
"TODO: Describe FastAPI setup for `main.py` \n",
"\n",
"In order to start the Classification service open a new terminal and execute the command\n",
"```shell\n",
"hypercorn .\\src\\examples\\issue_classification_user_journey\\ClassificationService:app\n",
"hypercorn ./src/examples/issue_classification_user_journey/main:app\n",
"```\n",
"\n",
"### Docker\n",
Expand All @@ -766,7 +766,7 @@
"```\n",
"Run the docker container and \n",
"```shell\n",
"docker run -p 8000:80 classification-service:local;2D \n",
"docker run -p 8000:80 classification-service:local \n",
"```\n",
"\n",
"poetry export --without-hashes --format=requirements.txt > requirements.txt\n",
Expand All @@ -776,6 +776,7 @@
"- Install `minikube`, see e.g. [here](https://minikube.sigs.k8s.io/docs/start/)\n",
"- `minikube start`\n",
"- Setup current shell to use minikube's docker daemon: `eval $(minikube -p minikube docker-env)`\n",
"- Export your AA token as a secret: `kubectl create secret generic aa-token --from-literal AA_TOKEN=*YourAAToken*`\n",
"- build docker container as above\n",
" - check if docker image exists:\n",
" - `minikube ssh`\n",
Expand Down Expand Up @@ -809,7 +810,7 @@
"name": "python",
"nbconvert_exporter": "python",
"pygments_lexer": "ipython3",
"version": "3.11.7"
"version": "3.11.8"
}
},
"nbformat": 4,
Expand Down
Loading