Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Il 408 artifactory deployment #724

Merged
merged 5 commits into from
Apr 10, 2024
Merged

Il 408 artifactory deployment #724

merged 5 commits into from
Apr 10, 2024

Conversation

NiklasKoehneckeAA
Copy link
Contributor

@NiklasKoehneckeAA NiklasKoehneckeAA commented Apr 10, 2024 •
edited
Loading

Description

No description.

Before Merging

  • Review the code changes
    • Unused print / comments / TODOs
    • Missing docstrings for functions that should have them
    • Consistent variable names
    • ...
  • Update changelog.md if necessary
  • Commit messages should contain a semantic label and the ticket number
    • Consider squashing if this is not the case

@NiklasKoehneckeAA NiklasKoehneckeAA force-pushed the IL-408-artifactory-deployment branch from b62beeb to cbc6631 Compare April 10, 2024 10:51
@NiklasKoehneckeAA NiklasKoehneckeAA merged commit f8bb381 into main Apr 10, 2024
4 checks passed
@NiklasKoehneckeAA NiklasKoehneckeAA deleted the IL-408-artifactory-deployment branch April 10, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NiklasKoehneckeAA @SebastianNiehusAA