Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OS Support for CI #720

Merged
merged 11 commits into from
Apr 11, 2024
Merged

OS Support for CI #720

merged 11 commits into from
Apr 11, 2024

Conversation

NiklasKoehneckeAA
Copy link
Contributor

@NiklasKoehneckeAA NiklasKoehneckeAA commented Apr 9, 2024 •
edited
Loading

Description

No description.

Before Merging

  • Review the code changes
    • Unused print / comments / TODOs
    • Missing docstrings for functions that should have them
    • Consistent variable names
    • ...
  • Update changelog.md if necessary
  • Commit messages should contain a semantic label and the ticket number
    • Consider squashing if this is not the case

@NiklasKoehneckeAA NiklasKoehneckeAA force-pushed the IL-393-ci-multi-os branch 10 times, most recently from 855b853 to 500f3ef Compare April 9, 2024 10:30
@NiklasKoehneckeAA NiklasKoehneckeAA changed the title refactor: extract current github jobs for reuse OS Support for CI Apr 11, 2024
@MerlinKallenbornAA MerlinKallenbornAA merged commit 294572e into main Apr 11, 2024
4 checks passed
@MerlinKallenbornAA MerlinKallenbornAA deleted the IL-393-ci-multi-os branch April 11, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MerlinKallenbornAA MerlinKallenbornAA MerlinKallenbornAA left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NiklasKoehneckeAA @MerlinKallenbornAA