Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: search eval #711

Merged
merged 9 commits into from
Apr 8, 2024
Merged

WIP: search eval #711

merged 9 commits into from
Apr 8, 2024

Conversation

NickyHavoc
Copy link
Collaborator

@NickyHavoc NickyHavoc commented Apr 8, 2024 •
edited by ivo-1
Loading

Description

No description.

Before Merging

  • Review the code changes
    • Unused print / comments / TODOs
    • Missing docstrings for functions that should have them
    • Consistent variable names
    • ...
  • Update changelog.md if necessary
  • Commit messages should contain a semantic label and the ticket number
    • Consider squashing if this is not the case

@ivo-1 ivo-1 merged commit b05d1fe into main Apr 8, 2024
4 checks passed
@ivo-1 ivo-1 deleted the search-eval branch April 8, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NickyHavoc @ivo-1