Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow negative min score in SearchQuery #1184

Merged
merged 2 commits into from
Dec 17, 2024
Merged

fix: allow negative min score in SearchQuery #1184

merged 2 commits into from
Dec 17, 2024

Conversation

Michael-JB
Copy link
Collaborator

Description

Update the SearchQuery model in document_index.py to allow a min_score between -1 and 1.

Before Merging

  • Review the code changes
    • Unused print / comments / TODOs
    • Missing docstrings for functions that should have them
    • Consistent variable names
    • ...
  • Update changelog.md if necessary
  • Commit messages should contain a semantic label and the ticket number
    • Consider squashing if this is not the case

@Michael-JB
fix: allow negative min score in SearchQuery
d10d2f2 
Update the `SearchQuery` model in `document_index.py` to allow a
`min_score` between -1 and 1.
@SebastianNiehusAA
Copy link
Contributor

Looks good

@SebastianNiehusAA SebastianNiehusAA merged commit 44805cc into main Dec 17, 2024
4 checks passed
@SebastianNiehusAA SebastianNiehusAA deleted the di-274-allow-negative-min-score branch December 17, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Michael-JB @SebastianNiehusAA