Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(document-index): retrieve chunks of an indexed document #1161

Merged
merged 3 commits into from
Dec 16, 2024
Merged

feat(document-index): retrieve chunks of an indexed document #1161

merged 3 commits into from
Dec 16, 2024

Conversation

TilTheunissenAA
Copy link
Contributor

@TilTheunissenAA TilTheunissenAA commented Nov 27, 2024 •
edited by SebastianNiehusAA
Loading

Description

No description.

Before Merging

  • Review the code changes
    • Unused print / comments / TODOs
    • Missing docstrings for functions that should have them
    • Consistent variable names
    • ...
  • Update changelog.md if necessary
  • Commit messages should contain a semantic label and the ticket number
    • Consider squashing if this is not the case

@TilTheunissenAA TilTheunissenAA force-pushed the di-190-retrieve-chunks branch 2 times, most recently from a5d506c to ce0dd52 Compare November 29, 2024 08:10
SebastianNiehusAA
SebastianNiehusAA reviewed Nov 29, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
SebastianNiehusAA
SebastianNiehusAA requested changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@SebastianNiehusAA SebastianNiehusAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and clean. It would be great if you could also add a small block about this to the document_index.ipynb

@SebastianNiehusAA SebastianNiehusAA merged commit 08331e1 into main Dec 16, 2024
4 checks passed
@SebastianNiehusAA SebastianNiehusAA deleted the di-190-retrieve-chunks branch December 16, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SebastianNiehusAA SebastianNiehusAA Awaiting requested review from SebastianNiehusAA

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TilTheunissenAA @SebastianNiehusAA