fix: reenable integration_test

Aleph-Alpha · Jun 7, 2024 · d81058f · d81058f
1 parent fcd9908
commit d81058f
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 13 deletions.
diff --git a/.github/workflows/sdk-tests.yml b/.github/workflows/sdk-tests.yml
@@ -122,13 +122,13 @@ jobs:
           - "4317:4317"
           - "4318:4318"
           - "16686:16686"
-#      trace-viewer:
-#        image: ghcr.io/aleph-alpha/trace-viewer-trace-viewer:main
-#        credentials:
-#          username: "unused"
-#          password: ${{ secrets.GITHUB_TOKEN }} # TODO: add PAT
-#        ports:
-#          - "3000:3000"
+      trace-viewer:
+        image: ghcr.io/aleph-alpha/trace-viewer-trace-viewer:main
+        credentials:
+          username: "unused"
+          password: ${{ secrets.GH_PAT }}
+        ports:
+          - "3000:3000"
     steps:
       - name: Checkout repository
         uses: actions/checkout@v4

diff --git a/docker-compose.yaml b/docker-compose.yaml
@@ -6,7 +6,16 @@ services:
       ES_JAVA_OPTS: "-Xms512m -Xmx512m"
       discovery.type: "single-node"
       xpack.security.enabled: "false"
+    command: ["elasticsearch", "-Elogger.level=ERROR"]
+    healthcheck:
+      test: ["CMD-SHELL", "curl --silent --fail localhost:9200/_cluster/health || exit 1"]
+      interval: 5s
+      timeout: 5s
+      retries: 3
   argilla:
+    depends_on:
+      argilla-elastic-search:
+        condition: service_healthy
     image: argilla/argilla-server:v1.26.1
     ports:
       - "6900:6900"
@@ -22,10 +31,10 @@ services:
       - "4318:4318"
       - "16686:16686"
     image: jaegertracing/all-in-one:1.35
-  # TODO: Below code should be enabled once the secret has been added to the CI. After that, also check tests in test_tracer.py
   # export GITHUB_TOKEN=...
   # echo $GITHUB_TOKEN | docker login ghcr.io -u your_email@for_github --password-stdin
-  # trace_viewer:
-  #   image: ghcr.io/aleph-alpha/trace-viewer-trace-viewer:main
-  #   ports:
-  #    - 3000:3000
+  # docker compose pull to update containers
+  trace_viewer:
+    image: ghcr.io/aleph-alpha/trace-viewer-trace-viewer:main
+    ports:
+     - 3000:3000
diff --git a/tests/core/tracer/test_tracer.py b/tests/core/tracer/test_tracer.py
@@ -226,7 +226,6 @@ def test_spans_cannot_be_used_as_context_twice(
             pass
 
 
-@pytest.mark.skip("Not yet implemented")
 @pytest.mark.docker
 @pytest.mark.parametrize(
     "tracer_fixture",