Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add GitHub Actions example for container image #33

Merged
merged 5 commits into from
Oct 18, 2021

Conversation

kevholmes
Copy link
Contributor

As requested here: go-reform/reform#299 (comment)

@kevholmes
Copy link
Contributor Author

Hi @AlekSi - let me know if this is on track or if there's anything else you'd like to see.

@AlekSi
Copy link
Owner

AlekSi commented Oct 18, 2021

Looks great. Could you also add instructions for .tar.gz please? I use something like that:

      - name: Install Go
        run: |
          sudo rm -fr /opt/hostedtoolcache/go /usr/local/go /usr/bin/go /bin/go
          curl -o go.tar.gz -L \
            https://github.com/AlekSi/golang-tip/releases/download/tip/master.linux-amd64.tar.gz
          sudo tar -C /usr/local -xzf go.tar.gz
          sudo ln -s /usr/local/go/bin/* /usr/local/bin/
          go version
          rm go.tar.gz

But that probably could be simplified.

@kevholmes
Copy link
Contributor Author

But that probably could be simplified.

TY for the example code. Doesn't get much simpler really! The .tar.gz example is much faster to run (48 seconds faster than container example) so I called that out also.

@kevholmes
Copy link
Contributor Author

kevholmes commented Oct 18, 2021

Also, I noticed that my PR is causing a bunch of builds. Maybe adding paths-ignore: ["**.md"] to your build.yml at line ~16 like:

  pull_request:
    paths-ignore: ["**.md"]

Would help those from executing every time I sync/you approve. These builds/checks would just skip and you could still approve the PR iirc - doesn't appear as tho you'd want a full re-build for doc changes PRs.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@AlekSi
Copy link
Owner

AlekSi commented Oct 18, 2021

Maybe adding paths-ignore: ["**.md"] to your build.yml

Yes, please :)

The .tar.gz example is much faster to run (48 seconds faster than container example) so I called that out also.

Maybe just say "it is faster" and put it first then? Not sure about the actual numbers

@AlekSi
Copy link
Owner

AlekSi commented Oct 18, 2021

Please click that button when done:
image

@kevholmes kevholmes requested a review from AlekSi October 18, 2021 20:19
@AlekSi AlekSi merged commit 8f2f3a4 into AlekSi:main Oct 18, 2021
@AlekSi
Copy link
Owner

AlekSi commented Oct 18, 2021

Merged, thank you!

@kevholmes kevholmes deleted the docs/gha_example branch October 18, 2021 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants