This repository has been archived by the owner on Apr 19, 2024. It is now read-only.
Added an option to add a comment to every select's option #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlecAivazis
approved these changes
May 7, 2022
|
@luanraithz the tests are failing - mind fixing them? |
|
Sorry, didn't see that. I'm on it |
mislav
suggested changes
May 11, 2022
examples/meals.go
Outdated
| @@ -0,0 +1,53 @@ | |||
| package main | |||
There was a problem hiding this comment.
Can the file meals.go be named something more descriptive of the feature it's demoing, such as select_description.go?
|
I think it's all solved, thanks for the review! |
|
@AlecAivazis How soon can we expect a release with this PR? |
|
Thanks for the ping! It's now been released as |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the pull request mentioned on #416