This repository has been archived by the owner on Apr 19, 2024. It is now read-only.
reverted konsole support which broke runereader #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlecAivazis
changed the title
|
I will look into it and try to fix it. Thank you for mentioning me. |
System-Glitch
added a commit
to System-Glitch/survey
that referenced
this pull request
Nov 6, 2020
…)" This reverts commit c1858c5.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a bug reported in #307 and reverts the changes made by @System-Glitch which seems to have broken runereader in both windows and the default mac terminal.
Unfortunately this means we don't currently support Konsole but that can come after this gets fixed.
cc @pantelis-karamolegkos