Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Alchemy Guides links #3148

Merged
merged 3 commits into from
Jan 8, 2025
Merged

Fix Alchemy Guides links #3148

merged 3 commits into from
Jan 8, 2025

Conversation

zirni
Copy link
Contributor

@zirni zirni commented Jan 8, 2025

  • Change http to https
  • Remove /stable

TODO

  • For /menues.html I didnt find an appropriate page to replace with

@zirni
Fix Alchemy Guides links
705aec8 
- Change http to https
- Remove /stable

TODO
- For /menues.html I didnt find an appropriate page to replace with
@zirni zirni requested a review from a team as a code owner January 8, 2025 12:01
@codecov Codecov
Copy link

codecov bot commented Jan 8, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.58%. Comparing base (b4b2471) to head (68f5b1d).
Report is 37 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3148      +/-   ##
==========================================
- Coverage   96.58%   96.58%   -0.01%     
==========================================
  Files         236      236              
  Lines        6334     6360      +26     
==========================================
+ Hits         6118     6143      +25     
- Misses        216      217       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tvdeyen
tvdeyen approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@tvdeyen tvdeyen added the backport-to-7.4-stable Needs to be backported to 7.4-stable label Jan 8, 2025
@tvdeyen tvdeyen merged commit 219819c into AlchemyCMS:main Jan 8, 2025
57 checks passed
@alchemycms-bot
Copy link
Collaborator

💔 All backports failed

Status Branch Result
❌ 7.4-stable Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

backport --pr 3148

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tvdeyen tvdeyen tvdeyen approved these changes

Assignees
No one assigned
Labels
backport-to-7.4-stable Needs to be backported to 7.4-stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zirni @alchemycms-bot @tvdeyen