Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.4-stable] Convert dialog class into esm #3119

Merged
merged 5 commits into from
Jan 4, 2025
Merged

[7.4-stable] Convert dialog class into esm #3119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1699853
Convert Alchemy.ImageOverlay into ES module
tvdeyen Sep 24, 2024
8c417bf
Convert Alchemy.Dialog into ES module
tvdeyen Sep 24, 2024
b338ef4
Remove the Sprockets manifest
tvdeyen Sep 24, 2024
6d702c3
Watch for confirm dialogs in Initializer module
tvdeyen Sep 24, 2024
3886107
refactor(Dialog): Adhere code climate
tvdeyen Sep 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions app/assets/javascripts/alchemy/admin.js
View file
Open in desktop

This file was deleted.

271 changes: 0 additions & 271 deletions app/assets/javascripts/alchemy/alchemy.dialog.js.coffee
View file
Open in desktop

This file was deleted.

54 changes: 0 additions & 54 deletions app/assets/javascripts/alchemy/alchemy.image_overlay.coffee
View file
Open in desktop

This file was deleted.

7 changes: 3 additions & 4 deletions app/javascript/alchemy_admin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,14 @@ import "select2"

import Rails from "@rails/ujs"

import GUI from "alchemy_admin/gui"
import { translate } from "alchemy_admin/i18n"
import { currentDialog, closeCurrentDialog } from "alchemy_admin/dialog"
import Dirty from "alchemy_admin/dirty"
import * as FixedElements from "alchemy_admin/fixed_elements"
import { growl } from "alchemy_admin/growler"
import ImageLoader from "alchemy_admin/image_loader"
import Initializer from "alchemy_admin/initializer"
import { LinkDialog } from "alchemy_admin/link_dialog"
import pictureSelector from "alchemy_admin/picture_selector"
import pleaseWaitOverlay from "alchemy_admin/please_wait_overlay"
import Sitemap from "alchemy_admin/sitemap"
import Spinner from "alchemy_admin/spinner"
Expand All @@ -42,14 +41,14 @@ if (typeof window.Alchemy === "undefined") {

// Enhance the global Alchemy object with imported features
Object.assign(Alchemy, {
closeCurrentDialog,
currentDialog,
...Dirty,
GUI,
t: translate, // Global utility method for translating a given string
FixedElements,
growl,
ImageLoader: ImageLoader.init,
LinkDialog,
pictureSelector,
pleaseWaitOverlay,
Sitemap,
Spinner,
Expand Down
Loading
Loading