Convert dialog class into esm #3050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3050 +/- ##
=======================================
Coverage 96.63% 96.63%
=======================================
Files 236 236
Lines 6331 6331
=======================================
Hits 6118 6118
Misses 213 213 ☔ View full report in Codecov by Sentry. |
tvdeyen
force-pushed
the
convert-dialog-into-esm
branch
2 times, most recently
from
a636d9a to
0dbe699
Compare
The last module before we can convert it's parent the Dialog.
The last CoffeeScript file and last JS file we compile with Sprockets. We can now remove Sprockets.
We do not compile any JS with Sprockets anymore \o/
tvdeyen
force-pushed
the
convert-dialog-into-esm
branch
from
0dbe699 to
e63f266
Compare
Alchemy.GUI.init is only used in this module. Combining it into the Initializer allows to reduce the dependencies of the Dialog class.
Try to adhere code climate issues
tvdeyen
force-pushed
the
convert-dialog-into-esm
branch
from
5e571f3 to
881a5f9
Compare
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
This converts the last two remaining coffeescript files into ES modules, so we can remove
Sprockets as our JS compiler and start using Propshaft for serving assets.
Checklist