Resource table fixes #3025
Merged
Resource table fixes #3025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes it more clear what this message is used for
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3025 +/- ##
=======================================
Coverage 96.47% 96.47%
=======================================
Files 237 237
Lines 6404 6404
=======================================
Hits 6178 6178
Misses 226 226 ☔ View full report in Codecov by Sentry. |
Make it clear that this is the size of the dialog that opens
Gets passed as title to the dialog that opens. Defaults to tooltip, because this is most of the time the same.
Make it a bit wider so it better fits long attribute fields.
tvdeyen
force-pushed
the
resource-table-fixes
branch
from
1f2ceaa to
2b4c344
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Several minor fixes for the recently introduced
Alchemy::Admin::Resource::Tableview component.Best reviewed commit by commit
Some highlights:
Checklist