Resource Table Component #2972
Merged
Resource Table Component #2972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reopend #2785, Github can't reopen a PR, if the branch was forced pushed... |
kulturbande
force-pushed
the
resource-table-component
branch
from
6e36c25 to
5ce71c7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2972 +/- ##
==========================================
+ Coverage 96.44% 96.46% +0.01%
==========================================
Files 233 237 +4
Lines 6307 6392 +85
==========================================
+ Hits 6083 6166 +83
- Misses 224 226 +2 ☔ View full report in Codecov by Sentry. |
kulturbande
force-pushed
the
resource-table-component
branch
from
5ce71c7 to
8ec6171
Compare
tvdeyen
reviewed
Jul 22, 2024
sascha-karnatz
force-pushed
the
resource-table-component
branch
11 times, most recently
from
d32458c to
d25861d
Compare
sascha-karnatz
force-pushed
the
resource-table-component
branch
from
d25861d to
42b9b3c
Compare
kulturbande
changed the title
sascha-karnatz
force-pushed
the
resource-table-component
branch
3 times, most recently
from
56582a5 to
0b3b09a
Compare
sascha-karnatz
force-pushed
the
resource-table-component
branch
from
0b3b09a to
8deb5ee
Compare
tvdeyen
reviewed
Aug 27, 2024
sascha-karnatz
force-pushed
the
resource-table-component
branch
from
8deb5ee to
8688b13
Compare
Add first try of a resource table. It is pretty raw and does not create the right output, but it is only a proposal.
Use the resource table - component for the default resource views.
Use the new table component for the language index - view and remove the old implementation.
Draw a check - icon if the value is boolean and is truthy. This was done previously in the view, but it is now easier to reuse these behavior in the table component.
The params - hash is at least in test environments not always set and it is better to use the default Rails methods to get the path to the controller.
sascha-karnatz
force-pushed
the
resource-table-component
branch
from
8688b13 to
70ab4d7
Compare
tvdeyen
reviewed
Aug 28, 2024
The implementation is pretty verbose, because the table itself has a lot of extra functionalities. It is not possible to use the default delete and edit buttons, because of different redirect links in the button configuration.
Use the new table component also for the page table. This table also has a lot of custom logic inside, that makes the configuration a bit verbose.
Use the new table component to render the tags table. The CSS had to be adjusted to change the width of the table columns.
Move the Button configuration into an own component and use the many slot mechanic of ViewComponent to render each container for each button.
sascha-karnatz
force-pushed
the
resource-table-component
branch
from
70ab4d7 to
c1068ce
Compare
tvdeyen
reviewed
Aug 29, 2024
| module Alchemy | ||
| module Admin | ||
| module Resource | ||
| # Renders a container for a button, which evaluate CanCanCan and shows a tooltip. This |
Use more view components to simplify the table and make it more readable. This also improves the before_render - method in the table. The content - "hack" is now not necessary anymore, because the view_context isn't used anymore and all other view components are placed as slots in the table.
The button method was a bit misleading, because it was providing only a container for a button. It now uses the with_action method, which is provided by the ViewComponent slot.
The variable is representing the header text of the column and is way easier to understand than the name label.
sascha-karnatz
force-pushed
the
resource-table-component
branch
from
c1068ce to
026ed13
Compare
tvdeyen
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Add an experimental resource table component. The idea is to make it easier to create resource tables without duplicating the table structure and be in sync between the index view and the row partial.
All tables (except page nodes table in page dialog) are using the page component. It works the same way as before, but it should be easier to create new resource views and maybe we can extend the behavior to provide other views (e.g. grid view).
Screenshots
An example:
Checklist