Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix language scope in picture description field #2876

Merged

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented May 16, 2024

We only allow to select from published languages,
so we should only display the select if there are
at least two published languages.

We only allow to select from published languages,
so we should only display the select if there are
at least two published languages.
@tvdeyen tvdeyen requested a review from a team as a code owner May 16, 2024 09:44
@tvdeyen tvdeyen added this to the 7.2 milestone May 16, 2024
Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.93%. Comparing base (1835cbd) to head (ca5bf09).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2876   +/-   ##
=======================================
  Coverage   95.93%   95.93%           
=======================================
  Files         229      229           
  Lines        6224     6224           
=======================================
  Hits         5971     5971           
  Misses        253      253           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tvdeyen tvdeyen merged commit b9a48a8 into AlchemyCMS:main May 16, 2024
35 of 36 checks passed
@tvdeyen tvdeyen deleted the fix-picture-description-language-select branch May 16, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants