Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate toolbar_button helper #2855

Merged
merged 1 commit into from
May 2, 2024
Merged

Deprecate toolbar_button helper #2855

merged 1 commit into from
May 2, 2024

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented May 1, 2024

What is this pull request for?

Use

render Alchemy::Admin::ToolbarButton.new

instead.

Checklist

Use

    render Alchemy::Admin::ToolbarButton.new

instead.
@tvdeyen tvdeyen added this to the 7.2 milestone May 1, 2024
@tvdeyen tvdeyen requested a review from a team as a code owner May 1, 2024 20:01
@tvdeyen tvdeyen changed the title Deprecate toolbar_button helper Deprecate toolbar_button helper May 1, 2024
Copy link

codecov bot commented May 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.86%. Comparing base (f123201) to head (6d728f4).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2855   +/-   ##
=======================================
  Coverage   95.86%   95.86%           
=======================================
  Files         229      229           
  Lines        6211     6212    +1     
=======================================
+ Hits         5954     5955    +1     
  Misses        257      257           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tvdeyen tvdeyen enabled auto-merge May 1, 2024 20:08
@tvdeyen tvdeyen merged commit 7444bc7 into main May 2, 2024
36 checks passed
@tvdeyen tvdeyen deleted the deprecate-toolbar_button branch May 2, 2024 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants