Add :contact_form_id to messages params in messages_controller
#2403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… certain attributes that developers may remove. Replace the templates with a single file.
… contact_form_mail.text.erb is a true empty template.
tvdeyen
reviewed
Dec 22, 2022
There was a problem hiding this comment.
Thanks. Instead of removing the mailer templates we should update the documentation. Also a test for the mailers controller would be necessary.
Note: The PR title is not very descriptive and the commit message for the contact_form_id misses a "why" in the commit body. It would be helpful to have a goog PR title and for future selfs, to have a good git commit message.
chiperific
changed the title
:contact_form_id to messages params in messages_controller
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Messages controller fix:
From:
params.require(:message).permit(*mailer_config["fields"])To:
params.require(:message).permit(*mailer_config["fields"], :contact_form_id)Why
The
Messagemodel requires a:contact_form_idto lookup anElementCloses #2402
Notable changes
contact_form_mailtemplates and replace with a single, truly bare template.Checklist