Pass crop parameter in default EssencePicture#picture_url_options #2098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, calling `my_essence.picture_url` without parameters would return an uncropped image be default. In order to get the cropped picture, one would have to add `my_essence.picture_url(crop: true)`. This is unintuitive: For an EssencePicture that I have cropped as a user (crop values are present), `essence.picture_url` as well as `essence.ingredient` should return the cropped version of the image.
tvdeyen
approved these changes
May 13, 2021
There was a problem hiding this comment.
I agree.
BUT, the impact his has is:
If the essence picture has crop values, but the settings[:crop] has since been set to false it still crops although it has been disabled after the essence got created. This makes the crop setting less important and removes it as a way to disable cropping later. A very rare use case IMO, but still worth noting and therefore a breaking change for v6
Thanks anyhow. I think this is a good change.
robinboening
pushed a commit
to robinboening/alchemy_cms
that referenced
this pull request
Jul 2, 2021
…chemyCMS#2098) Prior to this commit, calling `my_essence.picture_url` without parameters would return an uncropped image be default. In order to get the cropped picture, one would have to add `my_essence.picture_url(crop: true)`. This is unintuitive: For an EssencePicture that I have cropped as a user (crop values are present), `essence.picture_url` as well as `essence.ingredient` should return the cropped version of the image.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Prior to this commit, calling
my_essence.picture_urlwithoutparameters would return an uncropped image be default. In order to get
the cropped picture, one would have to add
my_essence.picture_url(crop: true). This is unintuitive: For an EssencePicture that I have croppedas a user (crop values are present),
essence.picture_urlas well asessence.ingredientshould return the cropped version of the image.Notable changes (remove if none)
EssencePicture#ingredientandEssencePicture.picture_urlnow return a cropped image by default if cropping is enabled in the element settings or if crop values are present.Checklist