Add Elements repository #2039
Merged
Add Elements repository #2039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamhoff
reviewed
Mar 1, 2021
mamhoff
approved these changes
Mar 1, 2021
mamhoff
reviewed
Mar 1, 2021
@mamhoff and it's a draft PR ;) But I still would like to hear your feedback |
tvdeyen
force-pushed
the
element-repository
branch
2 times, most recently
from
f85b455 to
7819787
Compare
tvdeyen
force-pushed
the
element-repository
branch
2 times, most recently
from
a136a91 to
75da500
Compare
This mimics the ActiveRecord interface of elements, but uses the eager loaded elements and POR methods to filter the collection
It is very common to chain ActiveRecord scopes to filter elements. This makes it possible with the ElementRepository by returning a new instance of the class for each of the scope methods.
These scopes are used on the ElementsFinder and needs to be supported.
This is way fast than using create and since we only use array methods in the repository class its totally safe to use it.
The elements repository uses array methods to filter, order and limit elements on a eager loaded ActiveRecord relation. This should help to prevent N+1 queries in the future.
tvdeyen
force-pushed
the
element-repository
branch
from
75da500 to
7ec0b43
Compare
mamhoff
reviewed
Mar 4, 2021
mamhoff
approved these changes
Mar 4, 2021
Rufo uses the same default as Rubocop here. By removing the override we use the dewfault of Rubocop.
tvdeyen
force-pushed
the
element-repository
branch
from
7ec0b43 to
9eb1a1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Adds a repository class that mimics the ActiveRecord interface of elements, but uses the eager loaded elements and POR methods to filter the collection.
With that we filter the elements in the elements finder (used in the
render_elementshelper) on a eager loaded elements collection.Checklist