Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix height of search input field #1973

Merged
merged 1 commit into from
Dec 1, 2020
Merged

Fix height of search input field #1973

merged 1 commit into from
Dec 1, 2020

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Dec 1, 2020

What is this pull request for?

Since we nested the input field in the label we cannot inherit the height anymore.

Screenshots

Screenshot from 2020-12-01 12-31-49

Screenshot from 2020-12-01 12-31-57

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

@tvdeyen
Fix height of search input field
f0aa560 
Since we nested the input field in the label we cannot inherit
the height anymore.
@tvdeyen tvdeyen added this to the 5.1 milestone Dec 1, 2020
@tvdeyen tvdeyen requested a review from mamhoff December 1, 2020 11:32
@tvdeyen tvdeyen merged commit c08678c into main Dec 1, 2020
@tvdeyen tvdeyen deleted the fix-search-field-height branch December 1, 2020 12:47
@tvdeyen
Copy link
Member Author

tvdeyen commented Dec 1, 2020

Travis has suspended our Open Source plan due to insufficient credits. I reached out to them and asked for help. Let's see

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mamhoff mamhoff mamhoff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.
2 participants
@tvdeyen @mamhoff