Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not move elements in tidy cells task (master) #1308

Merged
merged 2 commits into from
Sep 7, 2017

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Sep 1, 2017

Same as #1303 but for master

Copy link
Contributor

@mamhoff mamhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely approve this, and I disagree with codeclimate in this instance.

In the alchemy:tidy:cells task we move all elements that can be placed in a cell from the page
into the newly created cell. This is problamatic as this also moves elements that are in already existing
cells into the new cell.
@tvdeyen tvdeyen merged commit 6bb8634 into AlchemyCMS:master Sep 7, 2017
@tvdeyen tvdeyen deleted the fixes-tidy-task-4 branch September 7, 2017 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants