Merge pull request #2751 from AlchemyCMS/backport/7.1-stable/pr-2750

[7.1-stable] Merge pull request #2750 from tvdeyen/fix-sortable-elements

app/javascript/alchemy_admin/sortable_elements.js

@@ -29,12 +29,17 @@ function onSort(event) {
     params.parent_element_id = parentElement.dataset.elementId
   }
 
-  post(Alchemy.routes.order_admin_elements_path, params).then((response) => {
-    const data = response.data
-    Alchemy.growl(data.message)
-    Alchemy.PreviewWindow.refresh()
-    item.updateTitle(data.preview_text)
-  })
+  // Only send the request if the item was moved to a different container
+  // or sorted in the same list. Not on the old list in order to avoid incrementing
+  // the position of the other elements.
+  if (event.target === event.to) {
+    post(Alchemy.routes.order_admin_elements_path, params).then((response) => {
+      const data = response.data
+      Alchemy.growl(data.message)
+      Alchemy.PreviewWindow.refresh()
+      item.updateTitle(data.preview_text)
+    })
+  }
 }
 
 function onEnd() {

app/views/alchemy/admin/elements/create.js.erb

@@ -24,9 +24,7 @@
   $element_area.append(element_html);
 <%- end -%>
 
-<% if @element.fixed? %>
-  Alchemy.SortableElements('[name="fixed-element-<%= @element.id %>"] .nested-elements');
-<% end %>
+  Alchemy.SortableElements('[data-element-id="<%= @element.id %>"] .nested-elements');
 
   Alchemy.growl('<%= Alchemy.t(:successfully_added_element) %>');
   Alchemy.closeCurrentDialog();