Skip to content

Commit

Permalink
Merge pull request #3127 from AlchemyCMS/backport/7.0-stable/pr-3122
Browse files Browse the repository at this point in the history
[7.0-stable] CI: Run actions on ubuntu-22.04
  • Loading branch information
tvdeyen authored Jan 5, 2025
2 parents 82f4fbe + 65ecce8 commit 0217ffa
Show file tree
Hide file tree
Showing 5 changed files with 13 additions and 12 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/brakeman-analysis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ on:
jobs:
brakeman-scan:
name: Brakeman Scan
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
steps:
# Checkout the repository to the GitHub Actions runner
- name: Checkout
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ on: [pull_request]

jobs:
Standard:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
steps:
- name: Checkout code
uses: actions/checkout@v3
Expand All @@ -16,7 +16,7 @@ jobs:
- name: Lint Ruby files
run: bundle exec standardrb
Prettier:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
steps:
- name: Checkout
uses: actions/checkout@v3
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/stale.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ on:

jobs:
stale:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04

steps:
- uses: actions/stale@v5
Expand Down
8 changes: 5 additions & 3 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ on: [push, pull_request]

jobs:
RSpec:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
strategy:
fail-fast: false
matrix:
Expand Down Expand Up @@ -104,9 +104,11 @@ jobs:
if: failure()
with:
name: Screenshots
path: spec/dummy/tmp/screenshots
path: |
spec/dummy/tmp/capybara
spec/dummy/tmp/screenshots
Jest:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
env:
NODE_ENV: test
steps:
Expand Down
9 changes: 4 additions & 5 deletions app/models/concerns/alchemy/picture_thumbnails.rb
Original file line number Diff line number Diff line change
Expand Up @@ -102,11 +102,10 @@ def image_cropper_settings

# Show image cropping link for ingredient
def allow_image_cropping?
settings[:crop] && picture &&
picture.can_be_cropped_to?(
settings[:size],
settings[:upsample]
) && !!picture.image_file
settings[:crop] && picture&.can_be_cropped_to?(
settings[:size],
settings[:upsample]
) && !!picture.image_file
end

private
Expand Down

0 comments on commit 0217ffa

Please sign in to comment.