Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for disabled cache per page #58

Merged
merged 1 commit into from
Nov 15, 2021
Merged

Add support for disabled cache per page #58

merged 1 commit into from
Nov 15, 2021

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Nov 12, 2021

A page can have caching disabled via the cache: false flag on a pages page_layout definition.

@tvdeyen tvdeyen marked this pull request as draft November 12, 2021 22:59
@tvdeyen
Add support for disabled cache per page
1a47989 
A page can have caching disabled via the `cache: false` flag
on the page_layout definition.
@tvdeyen tvdeyen marked this pull request as ready for review November 12, 2021 23:04
@tvdeyen tvdeyen requested a review from mamhoff November 12, 2021 23:09
mamhoff
mamhoff approved these changes Nov 13, 2021
View reviewed changes
Copy link
Contributor

@mamhoff mamhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 tiny nit

app/controllers/alchemy/json_api/pages_controller.rb Show resolved Hide resolved
@tvdeyen tvdeyen merged commit 3a30aa9 into main Nov 15, 2021
@tvdeyen tvdeyen deleted the disable-page-cache-per-page branch November 15, 2021 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mamhoff mamhoff mamhoff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tvdeyen @mamhoff