Only include errors mixin in production mode #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need the error messages during development
tvdeyen
force-pushed
the
error-mixin-production-only
branch
from
fa6852e
to
e2d71b1
Compare
mamhoff
approved these changes
Nov 2, 2020
Honestly I think this should be dealt with upstream. The mixin provided is not very clever and hiding errors from logs is not very nice. |
tvdeyen
added a commit
that referenced
this pull request
Nov 6, 2020
- Add fixed\_elements relationship to element serializer [\#14](#14) ([tvdeyen](https://github.com/tvdeyen)) - Rename element\_type into name [\#13](#13) ([tvdeyen](https://github.com/tvdeyen)) - Only include errors mixin in production mode [\#12](#12) ([tvdeyen](https://github.com/tvdeyen))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need the error messages during development