Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

group_concat function doesn't work in lower case #1898

Closed
kdabir opened this issue Mar 14, 2024 · 3 comments · Fixed by #1900
Closed

group_concat function doesn't work in lower case #1898

kdabir opened this issue Mar 14, 2024 · 3 comments · Fixed by #1900
Labels
Good first issue Help wanted Related to: SQL compliance

Comments

@kdabir
Copy link

kdabir commented Mar 14, 2024 •
edited
Loading

when used as GROUP_CONCAT in query it works but when used group_concat it throws the following:

TypeError: alasql.fn["group_concat"] is not a function. (In 'alasql.fn["group_concat"](g['fieldName'])', 'alasql.fn["group_concat"]' is undefined)

this is not the case with other aggregation functions like count for example.
@vishal6557
Copy link
Contributor

Can you assign to me, @mathiasrw Thanks!

@Dedsec0098
Copy link

Hi I already have experience in fixing these issues. Can you please assign it to me?

vishal6557 pushed a commit to vishal6557/alasql that referenced this issue Mar 16, 2024
fix(group_concat): Added fix for group_concat AlaSQL#1898
79828a4
@vishal6557 vishal6557 mentioned this issue Mar 16, 2024
Merged
@mathiasrw mathiasrw assigned Dedsec0098 and unassigned Dedsec0098 Mar 18, 2024
mathiasrw pushed a commit that referenced this issue Mar 18, 2024
@vishal6557
Support lower case group_concat to fix #1898 (#1900)
7ab8535 
Co-authored-by: vishal diyora <[email protected]>
@mathiasrw
Copy link
Member

Fix released as part of v4.3.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good first issue Help wanted Related to: SQL compliance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(group_concat): Added fix for group_concat #1898 vishal6557/alasql
4 participants
@kdabir @mathiasrw @vishal6557 @Dedsec0098