Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SELECT RECORDSET * from csv returning empty columns if there's no matched rows #1547

Open
addlistener opened this issue Nov 28, 2022 · 8 comments
Open

SELECT RECORDSET * from csv returning empty columns if there's no matched rows #1547

addlistener opened this issue Nov 28, 2022 · 8 comments
Assignees
@aleeekhaan
Labels
Bug: Code provided to reproduced ! Bug Good first issue Help wanted Related to: Code quality

Comments

@addlistener
Copy link

image

Reproducing link: https://replit.com/@jchnxu/alasql-recordset-bug#index.js
@aleeekhaan
Copy link

Hi can I work on this??

@mathiasrw
Copy link
Member

Absolutely

@mathiasrw
Copy link
Member

Any luck @aleeekhaan ?

@aleeekhaan
Copy link

aleeekhaan commented May 18, 2023 •
edited
Loading

Working on it @mathiasrw.

@mathiasrw
Copy link
Member

Let me know if you need help @aleeekhaan

@aleeekhaan
Copy link

Hi @mathiasrw,

I have resolved the issue. Should I open a PR, so that the changes can be reviewed?

@mathiasrw
Copy link
Member

@aleeekhaan yes please!

aleeekhaan added a commit to aleeekhaan/alasql that referenced this issue Jun 28, 2023
@aleeekhaan
Fix RECORDSET returning empty columns if there's no matched rows issue …
617390c 
…AlaSQL#1547
aleeekhaan added a commit to aleeekhaan/alasql that referenced this issue Jun 28, 2023
@aleeekhaan
fix RECORDSET returning empty columns if there's no matched rows issue …
132bd54 
…AlaSQL#1547
@aleeekhaan aleeekhaan mentioned this issue Jun 28, 2023
Open
@aleeekhaan
Copy link

aleeekhaan commented Jun 28, 2023 •
edited
Loading

@mathiasrw A PR has been opened, #1733, please review code changes and let me know if any thing else is required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aleeekhaan aleeekhaan

Labels
Bug: Code provided to reproduced ! Bug Good first issue Help wanted Related to: Code quality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mathiasrw @addlistener @aleeekhaan