feat: custom classes for list wrapper and list items. #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into Akryum-master # Conflicts: # dist/vue-virtual-scroller.esm.js.map # dist/vue-virtual-scroller.min.js # dist/vue-virtual-scroller.min.js.map # dist/vue-virtual-scroller.umd.js.map
|
It would be incredibly cute if this PR could get reviewed ❤️ |
|
Wouldnt that make this dependant on their framework? |
|
This issue never got resolved :(. |
Akryum
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi !
Currently, the component auto adds
vue-recycle-scroller__item-wrapperclass on the wrapper element andvue-recycle-scroller__item-viewon the items.I know it is enought for styling via CSS.
But if you use some frameworks, for instance vuetify, it might be easier to actually add some of their existing classes to your wrapper and item. For such reasons, let me suggest this PR.
That allows for the new props
wrapperClassesanditemClassesas per below :