Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use NODE_ENV to determine if webpack should use production build instead of mode #114

Merged
merged 1 commit into from
Oct 20, 2019

Conversation

hmillison
Copy link
Contributor

This fixes an issue relating to this bug #13.

If you are trying to build your app for "production" with modes that are not named "production", this web server fails to start because our build was not properly configured for production.

This fixes this issue by using NODE_ENV to determine if you are building for production so we can have multiple modes for staging/production/development that all do a production build (https://cli.vuejs.org/guide/mode-and-env.html#example-staging-mode)

@rdunk
Copy link
Contributor

rdunk commented Oct 7, 2019

Any update on this one? I'm trying to build for several different environments using CLI modes but running into problems.

@Akryum Akryum merged commit ad49f88 into Akryum:master Oct 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants