Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility with vue-meta (htmlAttrs, bodyAttrs, ...) #123

Closed
frankfoerster opened this issue Jul 30, 2019 · 0 comments · Fixed by #124
Closed

Fix compatibility with vue-meta (htmlAttrs, bodyAttrs, ...) #123

frankfoerster opened this issue Jul 30, 2019 · 0 comments · Fixed by #124

Comments

@frankfoerster
Copy link
Contributor

Version: v0.5.0

Problem

The plugin currently minifies the html template and converts all characters to lowercase.

This breaks compatibility with some of the meta injections vue-meta offers, e.g.:
{{{ meta.inject().htmlAttrs.text() }}} and {{{ meta.inject().bodyAttrs.text() }}}.

When using those in the index.html template, the build step minifies and lowercases it, resulting in
{{{ meta.inject().htmlattrs.text() }}} and {{{ meta.inject().bodyattrs.text() }}}.

As a result the server-side rendering process throws an error (500) because it cannot resolve htmlattrs/bodyattrs.

Solution

a) Enable case sensitivity for the minification step on the html webpack plugin.
b) Make the options configurable via plugin config.

Pull request for a) follows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant