-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
In the past 6 months, `cucumber/cucumber`-repo has seen a variet of changes all of which have been fixed with this commit: * background to have `id` * rule to have `id` * examples to have `id` * ensure to only strip leading and trailing spaces in table cells. Keep newline intact * ensure escaped delimiter within doc_string is not recorded as escaped * doc_string has field change: contentType -> mediaType * ignore comments on tags See: cucumber/common#891 cucumber/common#880 cucumber/common#889 cucumber/common#800 At the time of this commit, master for `cucumber/cucumber` was at: a7c593f479e7ae739b49108f79bba4853352d99c
- Loading branch information
1 parent
a13b518
commit ef66980
Showing
157 changed files
with
361 additions
and
52,297 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 changes: 2 additions & 24 deletions
26
test/support/testdata/bad/inconsistent_cell_count.feature.errors.ndjson
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,24 +1,2 @@ | ||
{ | ||
"attachment": { | ||
"data": "(6:7): inconsistent cell count within the table", | ||
"source": { | ||
"location": { | ||
"column": 7, | ||
"line": 6 | ||
}, | ||
"uri": "testdata/bad/inconsistent_cell_count.feature" | ||
} | ||
} | ||
} | ||
{ | ||
"attachment": { | ||
"data": "(14:5): inconsistent cell count within the table", | ||
"source": { | ||
"location": { | ||
"column": 5, | ||
"line": 14 | ||
}, | ||
"uri": "testdata/bad/inconsistent_cell_count.feature" | ||
} | ||
} | ||
} | ||
{"parseError":{"message":"(6:7): inconsistent cell count within the table","source":{"location":{"column":7,"line":6},"uri":"testdata/bad/inconsistent_cell_count.feature"}}} | ||
{"parseError":{"message":"(14:5): inconsistent cell count within the table","source":{"location":{"column":5,"line":14},"uri":"testdata/bad/inconsistent_cell_count.feature"}}} |
13 changes: 1 addition & 12 deletions
13
test/support/testdata/bad/invalid_language.feature.errors.ndjson
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1 @@ | ||
{ | ||
"attachment": { | ||
"data": "(1:1): Language not supported: no-such", | ||
"source": { | ||
"location": { | ||
"column": 1, | ||
"line": 1 | ||
}, | ||
"uri": "testdata/bad/invalid_language.feature" | ||
} | ||
} | ||
} | ||
{"parseError":{"message":"(1:1): Language not supported: no-such","source":{"location":{"column":1,"line":1},"uri":"testdata/bad/invalid_language.feature"}}} |
26 changes: 2 additions & 24 deletions
26
test/support/testdata/bad/multiple_parser_errors.feature.errors.ndjson
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,24 +1,2 @@ | ||
{ | ||
"attachment": { | ||
"data": "(2:1): expected: #EOF, #Language, #TagLine, #FeatureLine, #Comment, #Empty, got 'invalid line here'", | ||
"source": { | ||
"location": { | ||
"column": 1, | ||
"line": 2 | ||
}, | ||
"uri": "testdata/bad/multiple_parser_errors.feature" | ||
} | ||
} | ||
} | ||
{ | ||
"attachment": { | ||
"data": "(9:1): expected: #EOF, #TableRow, #DocStringSeparator, #StepLine, #TagLine, #ExamplesLine, #ScenarioLine, #RuleLine, #Comment, #Empty, got 'another invalid line here'", | ||
"source": { | ||
"location": { | ||
"column": 1, | ||
"line": 9 | ||
}, | ||
"uri": "testdata/bad/multiple_parser_errors.feature" | ||
} | ||
} | ||
} | ||
{"parseError":{"message":"(2:1): expected: #EOF, #Language, #TagLine, #FeatureLine, #Comment, #Empty, got 'invalid line here'","source":{"location":{"column":1,"line":2},"uri":"testdata/bad/multiple_parser_errors.feature"}}} | ||
{"parseError":{"message":"(9:1): expected: #EOF, #TableRow, #DocStringSeparator, #StepLine, #TagLine, #ExamplesLine, #ScenarioLine, #RuleLine, #Comment, #Empty, got 'another invalid line here'","source":{"location":{"column":1,"line":9},"uri":"testdata/bad/multiple_parser_errors.feature"}}} |
13 changes: 1 addition & 12 deletions
13
test/support/testdata/bad/not_gherkin.feature.errors.ndjson
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1 @@ | ||
{ | ||
"attachment": { | ||
"data": "(1:1): expected: #EOF, #Language, #TagLine, #FeatureLine, #Comment, #Empty, got 'not gherkin'", | ||
"source": { | ||
"location": { | ||
"column": 1, | ||
"line": 1 | ||
}, | ||
"uri": "testdata/bad/not_gherkin.feature" | ||
} | ||
} | ||
} | ||
{"parseError":{"message":"(1:1): expected: #EOF, #Language, #TagLine, #FeatureLine, #Comment, #Empty, got 'not gherkin'","source":{"location":{"column":1,"line":1},"uri":"testdata/bad/not_gherkin.feature"}}} |
13 changes: 1 addition & 12 deletions
13
test/support/testdata/bad/single_parser_error.feature.errors.ndjson
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1 @@ | ||
{ | ||
"attachment": { | ||
"data": "(2:1): expected: #EOF, #Language, #TagLine, #FeatureLine, #Comment, #Empty, got 'invalid line here'", | ||
"source": { | ||
"location": { | ||
"column": 1, | ||
"line": 2 | ||
}, | ||
"uri": "testdata/bad/single_parser_error.feature" | ||
} | ||
} | ||
} | ||
{"parseError":{"message":"(2:1): expected: #EOF, #Language, #TagLine, #FeatureLine, #Comment, #Empty, got 'invalid line here'","source":{"location":{"column":1,"line":2},"uri":"testdata/bad/single_parser_error.feature"}}} |
12 changes: 1 addition & 11 deletions
12
test/support/testdata/bad/unexpected_eof.feature.errors.ndjson
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1 @@ | ||
{ | ||
"attachment": { | ||
"data": "(7:0): unexpected end of file, expected: #TagLine, #ScenarioLine, #Comment, #Empty", | ||
"source": { | ||
"location": { | ||
"line": 7 | ||
}, | ||
"uri": "testdata/bad/unexpected_eof.feature" | ||
} | ||
} | ||
} | ||
{"parseError":{"message":"(7:0): unexpected end of file, expected: #TagLine, #ScenarioLine, #Comment, #Empty","source":{"location":{"line":7},"uri":"testdata/bad/unexpected_eof.feature"}}} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
Feature: Whitespace in tags | ||
|
||
@a tag containing whitespace | ||
Scenario: minimalistic |
1 change: 1 addition & 0 deletions
1
test/support/testdata/bad/whitespace_in_tags.feature.errors.ndjson
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
{"parseError":{"message":"(3:3): A tag may not contain whitespace","source":{"location":{"column":3,"line":3},"uri":"testdata/bad/whitespace_in_tags.feature"}}} |
2 changes: 1 addition & 1 deletion
2
test/support/testdata/full_features/100-create-employee.feature.ast.ndjson
Large diffs are not rendered by default.
Oops, something went wrong.
2 changes: 1 addition & 1 deletion
2
test/support/testdata/full_features/200-get-employee.feature.ast.ndjson
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
{"gherkinDocument":{"uri":"/Users/kevinjohnson/projects/ex_gherkin/test/support/testdata/full_features/200-get-employee.feature","feature":{"location":{"line":1,"column":1},"language":"en","keyword":"Feature","name":"Get Employee","children":[{"background":{"location":{"line":3,"column":3},"keyword":"Background","steps":[{"location":{"line":5,"column":5},"keyword":"Given ","text":"an employee with the following attributes","dataTable":{"location":{"line":6,"column":7},"rows":[{"location":{"line":6,"column":7},"cells":[{"location":{"line":6,"column":9},"value":"id"},{"location":{"line":6,"column":15},"value":"firstName"},{"location":{"line":6,"column":27},"value":"lastName"},{"location":{"line":6,"column":38},"value":"dateOfBirth"},{"location":{"line":6,"column":52},"value":"startDate"},{"location":{"line":6,"column":65},"value":"employmentType"},{"location":{"line":6,"column":82},"value":"email"}],"id":"0"},{"location":{"line":7,"column":7},"cells":[{"location":{"line":7,"column":9},"value":"200"},{"location":{"line":7,"column":15},"value":"Rachel"},{"location":{"line":7,"column":27},"value":"Green"},{"location":{"line":7,"column":38},"value":"1990-01-01"},{"location":{"line":7,"column":52},"value":"2018-01-01"},{"location":{"line":7,"column":65},"value":"Permanent"},{"location":{"line":7,"column":82},"value":"[email protected]"}],"id":"1"}]},"id":"2"},{"location":{"line":9,"column":5},"keyword":"And ","text":"with the following phone numbers","dataTable":{"location":{"line":10,"column":7},"rows":[{"location":{"line":10,"column":7},"cells":[{"location":{"line":10,"column":9},"value":"id"},{"location":{"line":10,"column":15},"value":"type"},{"location":{"line":10,"column":24},"value":"isdCode"},{"location":{"line":10,"column":34},"value":"phoneNumber"},{"location":{"line":10,"column":48},"value":"extension"}],"id":"3"},{"location":{"line":11,"column":7},"cells":[{"location":{"line":11,"column":9},"value":"201"},{"location":{"line":11,"column":15},"value":"Mobile"},{"location":{"line":11,"column":24},"value":"+1"},{"location":{"line":11,"column":34},"value":"2141112222"},{"location":{"line":11,"column":58}}],"id":"4"},{"location":{"line":12,"column":7},"cells":[{"location":{"line":12,"column":9},"value":"202"},{"location":{"line":12,"column":15},"value":"Office"},{"location":{"line":12,"column":24},"value":"+1"},{"location":{"line":12,"column":34},"value":"8362223000"},{"location":{"line":12,"column":48},"value":"333"}],"id":"5"}]},"id":"6"},{"location":{"line":14,"column":5},"keyword":"When ","text":"employee already exists","id":"7"}]}},{"scenario":{"location":{"line":17,"column":3},"keyword":"Scenario","name":"GET BY ID","steps":[{"location":{"line":19,"column":5},"keyword":"When ","text":"user wants to get employee by id 200","id":"8"},{"location":{"line":20,"column":5},"keyword":"Then ","text":"the get 'IS SUCCESSFUL'","id":"9"},{"location":{"line":21,"column":5},"keyword":"And ","text":"following employee is returned","dataTable":{"location":{"line":22,"column":7},"rows":[{"location":{"line":22,"column":7},"cells":[{"location":{"line":22,"column":9},"value":"id"},{"location":{"line":22,"column":15},"value":"firstName"},{"location":{"line":22,"column":27},"value":"lastName"},{"location":{"line":22,"column":38},"value":"dateOfBirth"},{"location":{"line":22,"column":52},"value":"startDate"},{"location":{"line":22,"column":65},"value":"employmentType"},{"location":{"line":22,"column":82},"value":"email"}],"id":"10"},{"location":{"line":23,"column":7},"cells":[{"location":{"line":23,"column":9},"value":"200"},{"location":{"line":23,"column":15},"value":"Rachel"},{"location":{"line":23,"column":27},"value":"Green"},{"location":{"line":23,"column":38},"value":"1990-01-01"},{"location":{"line":23,"column":52},"value":"2018-01-01"},{"location":{"line":23,"column":65},"value":"Permanent"},{"location":{"line":23,"column":82},"value":"[email protected]"}],"id":"11"}]},"id":"12"},{"location":{"line":25,"column":5},"keyword":"And ","text":"following employee phone numbers are returned","dataTable":{"location":{"line":26,"column":7},"rows":[{"location":{"line":26,"column":7},"cells":[{"location":{"line":26,"column":9},"value":"id"},{"location":{"line":26,"column":15},"value":"type"},{"location":{"line":26,"column":24},"value":"isdCode"},{"location":{"line":26,"column":34},"value":"phoneNumber"},{"location":{"line":26,"column":48},"value":"extension"}],"id":"13"},{"location":{"line":27,"column":7},"cells":[{"location":{"line":27,"column":9},"value":"201"},{"location":{"line":27,"column":15},"value":"Mobile"},{"location":{"line":27,"column":24},"value":"+1"},{"location":{"line":27,"column":34},"value":"2141112222"},{"location":{"line":27,"column":58}}],"id":"14"},{"location":{"line":28,"column":7},"cells":[{"location":{"line":28,"column":9},"value":"202"},{"location":{"line":28,"column":15},"value":"Office"},{"location":{"line":28,"column":24},"value":"+1"},{"location":{"line":28,"column":34},"value":"8362223000"},{"location":{"line":28,"column":48},"value":"333"}],"id":"15"}]},"id":"16"}],"id":"17"}}]}}} | ||
{"gherkinDocument":{"feature":{"location":{"line":1,"column":1},"language":"en","keyword":"Feature","name":"Get Employee","children":[{"background":{"id":"8","location":{"line":3,"column":3},"keyword":"Background","steps":[{"location":{"line":5,"column":5},"keyword":"Given ","text":"an employee with the following attributes","dataTable":{"location":{"line":6,"column":7},"rows":[{"id":"0","location":{"line":6,"column":7},"cells":[{"location":{"line":6,"column":9},"value":"id"},{"location":{"line":6,"column":15},"value":"firstName"},{"location":{"line":6,"column":27},"value":"lastName"},{"location":{"line":6,"column":38},"value":"dateOfBirth"},{"location":{"line":6,"column":52},"value":"startDate"},{"location":{"line":6,"column":65},"value":"employmentType"},{"location":{"line":6,"column":82},"value":"email"}]},{"id":"1","location":{"line":7,"column":7},"cells":[{"location":{"line":7,"column":9},"value":"200"},{"location":{"line":7,"column":15},"value":"Rachel"},{"location":{"line":7,"column":27},"value":"Green"},{"location":{"line":7,"column":38},"value":"1990-01-01"},{"location":{"line":7,"column":52},"value":"2018-01-01"},{"location":{"line":7,"column":65},"value":"Permanent"},{"location":{"line":7,"column":82},"value":"[email protected]"}]}]},"id":"2"},{"location":{"line":9,"column":5},"keyword":"And ","text":"with the following phone numbers","dataTable":{"location":{"line":10,"column":7},"rows":[{"id":"3","location":{"line":10,"column":7},"cells":[{"location":{"line":10,"column":9},"value":"id"},{"location":{"line":10,"column":15},"value":"type"},{"location":{"line":10,"column":24},"value":"isdCode"},{"location":{"line":10,"column":34},"value":"phoneNumber"},{"location":{"line":10,"column":48},"value":"extension"}]},{"id":"4","location":{"line":11,"column":7},"cells":[{"location":{"line":11,"column":9},"value":"201"},{"location":{"line":11,"column":15},"value":"Mobile"},{"location":{"line":11,"column":24},"value":"+1"},{"location":{"line":11,"column":34},"value":"2141112222"},{"location":{"line":11,"column":58}}]},{"id":"5","location":{"line":12,"column":7},"cells":[{"location":{"line":12,"column":9},"value":"202"},{"location":{"line":12,"column":15},"value":"Office"},{"location":{"line":12,"column":24},"value":"+1"},{"location":{"line":12,"column":34},"value":"8362223000"},{"location":{"line":12,"column":48},"value":"333"}]}]},"id":"6"},{"location":{"line":14,"column":5},"keyword":"When ","text":"employee already exists","id":"7"}]}},{"scenario":{"id":"18","location":{"line":17,"column":3},"keyword":"Scenario","name":"GET BY ID","steps":[{"location":{"line":19,"column":5},"keyword":"When ","text":"user wants to get employee by id 200","id":"9"},{"location":{"line":20,"column":5},"keyword":"Then ","text":"the get 'IS SUCCESSFUL'","id":"10"},{"location":{"line":21,"column":5},"keyword":"And ","text":"following employee is returned","dataTable":{"location":{"line":22,"column":7},"rows":[{"id":"11","location":{"line":22,"column":7},"cells":[{"location":{"line":22,"column":9},"value":"id"},{"location":{"line":22,"column":15},"value":"firstName"},{"location":{"line":22,"column":27},"value":"lastName"},{"location":{"line":22,"column":38},"value":"dateOfBirth"},{"location":{"line":22,"column":52},"value":"startDate"},{"location":{"line":22,"column":65},"value":"employmentType"},{"location":{"line":22,"column":82},"value":"email"}]},{"id":"12","location":{"line":23,"column":7},"cells":[{"location":{"line":23,"column":9},"value":"200"},{"location":{"line":23,"column":15},"value":"Rachel"},{"location":{"line":23,"column":27},"value":"Green"},{"location":{"line":23,"column":38},"value":"1990-01-01"},{"location":{"line":23,"column":52},"value":"2018-01-01"},{"location":{"line":23,"column":65},"value":"Permanent"},{"location":{"line":23,"column":82},"value":"[email protected]"}]}]},"id":"13"},{"location":{"line":25,"column":5},"keyword":"And ","text":"following employee phone numbers are returned","dataTable":{"location":{"line":26,"column":7},"rows":[{"id":"14","location":{"line":26,"column":7},"cells":[{"location":{"line":26,"column":9},"value":"id"},{"location":{"line":26,"column":15},"value":"type"},{"location":{"line":26,"column":24},"value":"isdCode"},{"location":{"line":26,"column":34},"value":"phoneNumber"},{"location":{"line":26,"column":48},"value":"extension"}]},{"id":"15","location":{"line":27,"column":7},"cells":[{"location":{"line":27,"column":9},"value":"201"},{"location":{"line":27,"column":15},"value":"Mobile"},{"location":{"line":27,"column":24},"value":"+1"},{"location":{"line":27,"column":34},"value":"2141112222"},{"location":{"line":27,"column":58}}]},{"id":"16","location":{"line":28,"column":7},"cells":[{"location":{"line":28,"column":9},"value":"202"},{"location":{"line":28,"column":15},"value":"Office"},{"location":{"line":28,"column":24},"value":"+1"},{"location":{"line":28,"column":34},"value":"8362223000"},{"location":{"line":28,"column":48},"value":"333"}]}]},"id":"17"}]}}]},"uri":"/Users/kevinjohnson/projects/ex_gherkin/test/support/testdata/full_features/200-get-employee.feature"}} |
Oops, something went wrong.