Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow iframes on meeting minutes #35

Merged
merged 2 commits into from
Sep 20, 2023

Conversation

fblupi
Copy link

@fblupi fblupi commented Sep 12, 2023

🎩 What? Why?

Allow meeting minutes to show videos.

📌 Related Issues

  • Fixes DECIDIM-753

Testing

Close a meeting adding a video in the closing minutes and see the result.

📷 Screenshots

Screenshot 2023-09-12 at 17-08-25 Neque facilis  - Meetings - Velit enim quam rerum aut  - Schuppe Inc

♥️ Thank you!

@fblupi fblupi requested a review from davidbeig September 12, 2023 15:09
Copy link

@davidbeig davidbeig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected!

I will approve this PR, but we'll wait until we have a reply about the CI integration, since the tests have broken down due to some changes in chromedriver version we are using in the workflow.

…elona/decidim into fix/allow-iframes-on-meetings-minutes
@fblupi fblupi merged commit 3ac5766 into release/0.27-stable-bcn Sep 20, 2023
12 checks passed
@fblupi fblupi deleted the fix/allow-iframes-on-meetings-minutes branch September 20, 2023 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants